Code Climate has analyzed commit d7adb9a and detected 1 issue on this pull request.

Here's the issue category breakdown:

View more on Code Climate.

I think reduce 3 lines in resource_generator is impossible, we can reduce one here and move first " if " to first line:

fields[name] =
              if association.polymorphic?
                field_with_polymorphic_association(association)
              elsif association.is_a?(ActiveRecord::Reflection::ThroughReflection)
                field_from_through_association(association)
              else
                ::Avo::Mappings::ASSOCIATIONS_MAPPING[association.class]
              end

Of course if we want to keep the code readable

@Nevelito, I noticed that the generated types aren't constants.

They should be formatted like this: types: [Team, Project, Post, Fish]

Alternatively, types: [::Team, ::Project, ::Post, ::Fish] is also valid.

However, my last suggestion mistakenly converted types: [:Team, :Project, :Post, :Fish] into types: ["Team", "Project", "Post", "Fish"], both of which are incorrect.

I tried to use constantize witch should fix this issue but it returns types like this

types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ...

I tried to use constantize witch should fix this issue but it returns types like this

types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ...

I know, I don't know a easy way to achieve this, could you do some research on this please?

I created alias with new inspect function and keep original inspect in function original_inspect, now it works as it should but let me know what you think

I created alias with new inspect function and keep original inspect in function original_inspect, now it works as it should but let me know what you think

@Nevelito you did that change on the spec/dummy/app/models/application_record.rb which is inside Avo's dummy application. What will happen on user's applications that will not have this monkey patch? Most provably will not work as expected and the types will be rendered as: types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ... which is not ideal. We want this way of rendering types: types: [Team, Project, Post, Fish] on all the applications

Suggesting this change to all the users is not ideal and monkey patching the ActiveRecord::Base it's also not reasonable.

Let's try to achieve this output: types: [Team, Project, Post, Fish] without monkey-patches if possible

I am not sure if it is possible, I tried to find something but nothing works, only changing inspect gave us wanted result but I see that we can not make like that because of this is in dummy app. I not sure what can we do now.